netdev - Re: [PATCH v3 net-next 0/7] udp: Flow dissection for tunnels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161018.140315.1520738555319027922.davem@davemloft.net>
Date:   Tue, 18 Oct 2016 14:03:15 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     tom@...bertland.com
Cc:     netdev@...r.kernel.org, kernel-team@...com
Subject: Re: [PATCH v3 net-next 0/7] udp: Flow dissection for tunnels

From: Tom Herbert <tom@...bertland.com>
Date: Tue, 18 Oct 2016 10:02:36 -0700

> v3:
>   - Fix build issues with modules that call IPv6 functions and
>     CONFIG_INET is not set.
>   - Fix compilation error in init'ing .flow_dissect in IPv6 UDP
>     offload.

Still doesn't build:

net/ipv6/udp_offload.c:208:19: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
   .flow_dissect = udp6_flow_dissect,
                   ^
net/ipv6/udp_offload.c:208:19: note: (near initialization for ‘udpv6_offload.callbacks.flow_dissect’)
cc1: some warnings being treated as errors
scripts/Makefile.build:289: recipe for target 'net/ipv6/udp_offload.o' failed
make[2]: *** [net/ipv6/udp_offload.o] Error 1
make[2]: *** Waiting for unfinished jobs....
scripts/Makefile.build:440: recipe for target 'net/ipv6' failed
make[1]: *** [net/ipv6] Error 2
make[1]: *** Waiting for unfinished jobs....
Makefile:969: recipe for target 'net' failed
make: *** [net] Error 2
make: *** Waiting for unfinished jobs....

The final argument to udp6_flow_dissect() is marked const but that is not what the
method definition wants.