netdev - Re: [PATCH 21/28] net/hyperv: avoid uninitialized variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20161018.142110.10381887028686813.davem@davemloft.net>
Date:   Tue, 18 Oct 2016 14:21:10 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     kys@...rosoft.com, haiyangz@...rosoft.com,
        torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
        vkuznets@...hat.com, stephen@...workplumber.org,
        sixiao@...rosoft.com, devel@...uxdriverproject.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH 21/28] net/hyperv: avoid uninitialized variable

From: Arnd Bergmann <arnd@...db.de>
Date: Tue, 18 Oct 2016 00:16:09 +0200

> The hdr_offset variable is only if we deal with a TCP or UDP packet,
> but as the check surrounding its usage tests for skb_is_gso()
> instead, the compiler has no idea if the variable is initialized
> or not at that point:
> 
> drivers/net/hyperv/netvsc_drv.c: In function ‘netvsc_start_xmit’:
> drivers/net/hyperv/netvsc_drv.c:494:42: error: ‘hdr_offset’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
> 
> This adds an additional check for the transport type, which
> tells the compiler that this path cannot happen. Since the
> get_net_transport_info() function should always be inlined
> here, I don't expect this to result in additional runtime
> checks.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied.