netdev - Re: [PATCH] ipv6: fix signedness of tmp_prefered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20161018.142525.1262217492229127435.davem@davemloft.net>
Date:   Tue, 18 Oct 2016 14:25:25 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     jbohac@...e.cz
Cc:     julia.lawall@...6.fr, kuznet@....inr.ac.ru, jmorris@...ei.org,
        yoshfuji@...ux-ipv6.org, kaber@...sh.net, netdev@...r.kernel.org,
        kbuild-all@...org
Subject: Re: [PATCH] ipv6: fix signedness of tmp_prefered_lft underflow
 check

From: Jiri Bohac <jbohac@...e.cz>
Date: Tue, 18 Oct 2016 17:01:54 +0200

> Commit 76506a986dc31394fd1f2741db037d29c7e57843 (IPv6: fix
> DESYNC_FACTOR) introduced a buggy check for underflow of
> tmp_prefered_lft. tmp_prefered_lft is unsigned, so the condition
> is always false.
> 
> Signed-off-by: Jiri Bohac <jbohac@...e.cz>
> Reported-by: Julia Lawall <julia.lawall@...6.fr>
> Fixes: 76506a986dc3 ("IPv6: fix DESYNC_FACTOR")

Does the check make any sense at all?  I'd say just remove it.