netdev - Re: [PATCH net-next] openvswitch: remove unnecessary EXPORT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOrHB_CkJ0vz3HekYU4HA6rukgE3g1j6ECFyY+RxZjPV9uwjYw@mail.gmail.com>
Date:   Tue, 18 Oct 2016 12:48:33 -0700
From:   Pravin Shelar <pshelar@....org>
To:     Jiri Benc <jbenc@...hat.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        ovs dev <dev@...nvswitch.org>
Subject: Re: [PATCH net-next] openvswitch: remove unnecessary EXPORT_SYMBOLs

On Tue, Oct 18, 2016 at 4:47 AM, Jiri Benc <jbenc@...hat.com> wrote:
> Many symbols exported to other modules are really used only by
> openvswitch.ko. Remove the exports.
>
> Tested by loading all 4 openvswitch modules, nothing breaks.
>
> Signed-off-by: Jiri Benc <jbenc@...hat.com>
> ---
>  net/openvswitch/datapath.c     | 2 --
>  net/openvswitch/vport-netdev.c | 1 -
>  net/openvswitch/vport.c        | 2 --
>  3 files changed, 5 deletions(-)
>
...
...
> @@ -479,7 +478,6 @@ void ovs_vport_deferred_free(struct vport *vport)
>
>         call_rcu(&vport->rcu, free_vport_rcu);
>  }
> -EXPORT_SYMBOL_GPL(ovs_vport_deferred_free);
>

ovs_vport_deferred_free() is not used anywhere. can you remove it?