netdev - Re: [Patch net] ipv6: fix a potential deadlock in do_ipv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM_iQpXNbc1pphwfvUoFXE318pgVZdkvHWKG98kUyntUno3Cqw@mail.gmail.com>
Date:   Wed, 19 Oct 2016 16:41:44 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Baozeng Ding <sploving1@...il.com>,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Subject: Re: [Patch net] ipv6: fix a potential deadlock in do_ipv6_setsockopt()

On Wed, Oct 19, 2016 at 4:38 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
>> diff --git a/net/ipv6/af_inet6.c b/net/ipv6/af_inet6.c
>> index 46ad699..b8c8d20 100644
>> --- a/net/ipv6/af_inet6.c
>> +++ b/net/ipv6/af_inet6.c
>> @@ -414,7 +414,9 @@ int inet6_release(struct socket *sock)
>>               return -EINVAL;
>>
>>       /* Free mc lists */
>> +     rtnl_lock();
>
> Certainly not.
>
> Some people want IPv6 being reasonably fast.

Oh, good catch, I should move the 'if' check out too...