netdev - Re: [Patch net] net: saving irq context for peernet2id()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpUjbfMdn4wBL=ibQd=mJmKS+Jh-LmsM_LEz8SkOwcPV0A@mail.gmail.com>
Date:   Thu, 20 Oct 2016 10:17:23 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Nicolas Dichtel <nicolas.dichtel@...nd.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Stephen Smalley <sds@...ho.nsa.gov>, Elad Raz <e@...draz.com>,
        Paul Moore <paul@...l-moore.com>
Subject: Re: [Patch net] net: saving irq context for peernet2id()

On Thu, Oct 20, 2016 at 3:17 AM, Nicolas Dichtel
<nicolas.dichtel@...nd.com> wrote:
>
> Now, we see that "it's needed" and that the analysis was wrong. If a race is
> introduced by this patch, it will be hard to detect and fix it.

It is _not_ needed for protection, it is needed to shut up a warning, I thought
this is pretty clear in the changelog.

If we could invent some way to save BH (*lock_bhsave()), we don't need
to bother this at all, currently we don't.