netdev - Re: [PATCH] davinci_emac: fix setting the mac from DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161020124149.v47amnfbisndai4q@atomide.com>
Date:   Thu, 20 Oct 2016 05:41:50 -0700
From:   Tony Lindgren <tony@...mide.com>
To:     Jeroen Hofstee <jhofstee@...tronenergy.com>
Cc:     netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
        Anant Gole <anantgole@...com>,
        Chaithrika U S <chaithrika@...com>,
        linux-omap@...r.kernel.org
Subject: Re: [PATCH] davinci_emac: fix setting the mac from DT

* Jeroen Hofstee <jhofstee@...tronenergy.com> [161019 12:39]:
> commit 9120bd6e9f77 ("net: davinci_emac: Get device dm816x MAC address
> using the cpsw code") sets the mac address to the one stored in the chip
> unconditionally, overwritten the one already set from the device tree.
> This patch makes sure the mac from DT is preserved.
> 
> On a am3517 this address is incorrectly read as all zeros, making it
> impossible to set a valid mac address without this patch.

OK, at least I don't have better ideas for fixing this:

Acked-by: Tony Lindgren <tony@...mide.com>