netdev - Re: [PATCH] net: sched: make default fifo qdiscs appear in the dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 21 Oct 2016 06:14:23 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Jiri Kosina <jikos@...nel.org>
Cc:     Jamal Hadi Salim <jhs@...atatu.com>, Phil Sutter <phil@....cc>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        "David S. Miller" <davem@...emloft.net>,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] net: sched: make default fifo qdiscs appear in the dump

On Fri, 2016-10-21 at 14:56 +0200, Jiri Kosina wrote:
> On Fri, 21 Oct 2016, Eric Dumazet wrote:
> 
> > Some of us are dealing with huge HTB hierarchies, so adding default fifo
> > in the dump will add more data pumped from the kernel.
> > 
> > BwE [1] for instance dumps qdisc/classes every 5 seconds.
> > 
> > I guess we'll need to not pull this patch in our kernels.
> 
> Okay, so I probably misunderstood you here:
> 
> 	https://marc.info/?l=linux-kernel&m=146073234818214&w=2
> 
> as I thought that as long as we move towards the hashtable, you wouldn't 
> have any issues with this.
> 
> I'd really like to unhide the default qdiscs, it makes little sense to be 
> inconsistent in this way.
> 
> Random shot into darkness -- how about making this a 
> CONFIG/sysctl-selectable?

Oh sorry for the confusion, I believe your patch is fine.

We could add an netlink attribute later for the users that really do not
want default fifo being dumped, but there is no hurry.

Acked-by: Eric Dumazet <edumazet@...gle.com>