netdev - Re: commit-3ac72b7b63d5 breaks networking on iMX28

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fea86fa6-d74a-43ff-cf60-0d375336a5ba@nelint.com>
Date:   Fri, 21 Oct 2016 06:39:35 -0700
From:   Eric Nelson <eric@...int.com>
To:     Henri Roosen <henri.roosen@...zinger.com>, fugang.duan@....com,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: commit-3ac72b7b63d5 breaks networking on iMX28

Hi Henri,

On 10/21/2016 02:19 AM, Henri Roosen wrote:
> Hi,
> 
> Unfortunately commit-3ac72b7b63d5 "net: fec: align IP header in
> hardware" breaks networking on an iMX28 system.
> 
> The commit seems valid for iMX6, where it is tested okay and solves the
> unaligned accesses.
> 
> On iMX28 I still see unaligned accesses and networking is broken. Can
> anyone confirm this?
> 

Reading the i.MX28 reference manual, it appears that this SoC doesn't
have the RACC bit, and I missed removal of the FEC_QUIRK_HAS_RACC flag.

Can you try with this patch?

diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/net/ethernet/freescale/fec_main.c
index 692ee24..db5eee9 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -96,7 +96,7 @@ static struct platform_device_id fec_devtype[] = {
}, {
.name = "imx28-fec",
.driver_data = FEC_QUIRK_ENET_MAC | FEC_QUIRK_SWAP_FRAME |
- FEC_QUIRK_SINGLE_MDIO | FEC_QUIRK_HAS_RACC,
+ FEC_QUIRK_SINGLE_MDIO,
}, {
.name = "imx6q-fec",
.driver_data = FEC_QUIRK_ENET_MAC | FEC_QUIRK_HAS_GBIT |

Please advise,


Eric