netdev - Re: commit-3ac72b7b63d5 breaks networking on iMX28

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9d3634bc-7778-ffc1-67bf-6fdac0078ac3@nelint.com>
Date:   Fri, 21 Oct 2016 06:46:47 -0700
From:   Eric Nelson <eric@...int.com>
To:     Henri Roosen <henri.roosen@...zinger.com>, fugang.duan@....com,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: commit-3ac72b7b63d5 breaks networking on iMX28

Hi Henri,

On 10/21/2016 06:39 AM, Eric Nelson wrote:
> Hi Henri,
> 
> On 10/21/2016 02:19 AM, Henri Roosen wrote:
>> Hi,
>>
>> Unfortunately commit-3ac72b7b63d5 "net: fec: align IP header in
>> hardware" breaks networking on an iMX28 system.
>>
>> The commit seems valid for iMX6, where it is tested okay and solves the
>> unaligned accesses.
>>
>> On iMX28 I still see unaligned accesses and networking is broken. Can
>> anyone confirm this?
>>
> 
> Reading the i.MX28 reference manual, it appears that this SoC doesn't
> have the RACC bit, and I missed removal of the FEC_QUIRK_HAS_RACC flag.
> 

Sorry. I was wrong.

The register (offset 0x1c4) is present, including the SHIFT16 bit, but
the register is named differently (HW_ENET_MAC_IPACCRXCONF).