netdev - question about function igmp_stop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <580DF574.6070905@hisilicon.com>
Date:   Mon, 24 Oct 2016 19:50:12 +0800
From:   Dongpo Li <lidongpo@...ilicon.com>
To:     netdev <netdev@...r.kernel.org>
Subject: question about function igmp_stop_timer() in net/ipv4/igmp.c

Hello

We encountered a multicast problem when two set-top box(STB) join the same multicast group and leave.
The two boxes can join the same multicast group
but only one box can send the IGMP leave group message when leave,
the other box does not send the IGMP leave message.
Our boxes use the IGMP version 2.

I added some debug info and found the whole procedure is like this:
(1) Box A joins the multicast group 225.1.101.145 and send the IGMP v2 membership report(join group).
(2) Box B joins the same multicast group 225.1.101.145 and also send the IGMP v2 membership report(join group).
(3) Box A receives the IGMP membership report from Box B and kernel calls igmp_heard_report().
    This function will call igmp_stop_timer(im).
    In function igmp_stop_timer(im), it tries to delete IGMP timer and does the following:
        im->tm_running = 0;
        im->reporter = 0;
(4) Box A leaves the multicast group 225.1.101.145 and kernel calls
    ip_mc_leave_group -> ip_mc_dec_group -> igmp_group_dropped.
    But in function igmp_group_dropped(), the im->reporter is 0, so the kernel does not send the IGMP leave message.

I think there may be some problem in step (3).
The function igmp_stop_timer(im) should not set im->reporter to 0 if the IGMP timer has expired.
It should only work if the IGMP timer is running and does not send the IGMP join message.
I'm not sure whether it's a problem and hope any advice.

Thanks!

    Regards,
    Dongpo

.