netdev - Re: [PATCH] net: skip genenerating uevents for network namespaces that are exiting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM_iQpUznmhpZ=N5_x5AD_DivdEFcLJKV69br12fv2zpd4sqjQ@mail.gmail.com>
Date:   Mon, 24 Oct 2016 10:17:12 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Andrey Vagin <avagin@...nvz.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Linux Containers <containers@...ts.linux-foundation.org>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        "Eric W . Biederman" <ebiederm@...ssion.com>
Subject: Re: [PATCH] net: skip genenerating uevents for network namespaces
 that are exiting

On Sat, Oct 22, 2016 at 12:37 AM, Andrey Vagin <avagin@...nvz.org> wrote:
> Hi Cong,
>
> On Thu, Oct 20, 2016 at 10:25 PM, Andrey Vagin <avagin@...nvz.org> wrote:
>> On Thu, Oct 20, 2016 at 8:10 PM, Cong Wang <xiyou.wangcong@...il.com> wrote:
>>> On Thu, Oct 20, 2016 at 7:46 PM, Andrei Vagin <avagin@...nvz.org> wrote:
>>>> No one can see these events, because a network namespace can not be
>>>> destroyed, if it has sockets.
>>>>
>>>
>>> Are you sure? kobject_uevent_env() seems sending uevents to all
>>> network namespaces.
>>
>> kobj_bcast_filter() checks that a kobject namespace is equal to a
>> socket namespace.
>
> Today I've checked that it really works as I read from the source code.
> I use this tool to read events:
> https://gist.github.com/avagin/430ba431fc2972002df40ebe6a048b36
>
> And I see that events from non-network devices are delivered to all sockets,
> but events from network devices are delivered only to sockets from
> a network namespace where a device is operated.

I missed it, it makes sense now. Please consider adding a comment in
the code or expanding your changelog for reference.

Thanks!