netdev - Re: [PATCH] cw1200: fix bogus maybe-uninitialized warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 25 Oct 2016 14:13:52 -0400
From:   Solomon Peachy <pizza@...ftnet.org>
To:     David Laight <David.Laight@...LAB.COM>
Cc:     "'Arnd Bergmann'" <arnd@...db.de>,
        Kalle Valo <kvalo@...eaurora.org>,
        Johannes Berg <johannes.berg@...el.com>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cw1200: fix bogus maybe-uninitialized warning

On Tue, Oct 25, 2016 at 01:24:55PM +0000, David Laight wrote:
> > -	if (count > 1) {
> > -		/* We already released one buffer, now for the rest */
> > -		ret = wsm_release_tx_buffer(priv, count - 1);
> > -		if (ret < 0)
> > -			return ret;
> > -		else if (ret > 0)
> > -			cw1200_bh_wakeup(priv);
> > -	}
> > +	/* We already released one buffer, now for the rest */
> > +	ret = wsm_release_tx_buffer(priv, count - 1);
> > +	if (ret < 0)
> > +		return ret;
> > +
> > +	if (ret > 0)
> > +		cw1200_bh_wakeup(priv);
> 
> That doesn't look equivalent to me (when count == 1).

I concur, this patch should not be applied in its current form.

 - Solomon
-- 
Solomon Peachy        		       pizza at shaftnet dot org
Delray Beach, FL                          ^^ (email/xmpp) ^^
Quidquid latine dictum sit, altum viditur.

Download attachment "signature.asc" of type "application/pgp-signature" (164 bytes)