netdev - Re: [PATCH] netfilter: fix type mismatch with error return from nft_parse_u32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161025195556.GA10443@tuxdriver.com>
Date:   Tue, 25 Oct 2016 15:55:56 -0400
From:   "John W. Linville" <linville@...driver.com>
To:     netfilter-devel@...r.kernel.org
Cc:     Patrick McHardy <kaber@...sh.net>,
        Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Laura Garcia Liebana <nevola@...il.com>,
        Pablo Neira Ayuso <pablo@...filter.org>,
        Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH] netfilter: fix type mismatch with error return from
 nft_parse_u32_check

On Tue, Oct 25, 2016 at 03:08:04PM -0400, John W. Linville wrote:
> Commit 36b701fae12ac ("netfilter: nf_tables: validate maximum value of
> u32 netlink attributes") introduced nft_parse_u32_check with a return
> value of "unsigned int", yet on error it returns "-ERANGE".
> 
> This patch corrects the mismatch by changing the return value to "int",
> which happens to match the actual users of nft_parse_u32_check already.
> 
> Found by Coverity, CID 1373930.
> 
> Note that commit 21a9e0f1568ea ("netfilter: nft_exthdr: fix error
> handling in nft_exthdr_init()) attempted to address the issue, but
> did not address the return type of nft_parse_u32_check.
> 
> Signed-off-by: John W. Linville <linville@...driver.com>
> Cc: Laura Garcia Liebana <nevola@...il.com>
> Cc: Pablo Neira Ayuso <pablo@...filter.org>
> Cc: Dan Carpenter <dan.carpenter@...cle.com>
> Fixes: 0eadf37afc250 ("netfilter: nf_tables: validate maximum value...")

The Fixes line is incorrect -- corrected patch to follow!

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@...driver.com			might be all we have.  Be ready.