netdev - RE: [PATCH 3/5] genetlink: statically initialize families

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 25 Oct 2016 11:25:38 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Johannes Berg' <johannes@...solutions.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH 3/5] genetlink: statically initialize families

From: Johannes Berg
> Sent: 24 October 2016 13:56
> On Mon, 2016-10-24 at 14:40 +0200, Johannes Berg wrote:
> > From: Johannes Berg <johannes.berg@...el.com>
> >
> > Instead of providing macros/inline functions to initialize
> > the families, make all users initialize them statically and
> > get rid of the macros.
> >
> > This reduces the kernel code size by about 1.6k on x86-64
> > (with allyesconfig).
> 
> Actually, with the new system where it's not const, I could even split
> this up and submit per subsystem, i.e. the fourth patch doesn't depend
> on it. I thought it would, since I wanted to make it const, but since I
> failed it doesn't actually have that dependency.

Actually, why aren't the structures 'const' ?

You could use a #define to set the .ops and .n_ops fields.
(and maybe .module = THIS_MODULE as well).

	David