netdev - Re: [PATCH net] bpf: fix samples to add fake KBUILD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161026164436.GA38823@ast-mbp.thefacebook.com>
Date:   Wed, 26 Oct 2016 09:44:38 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Daniel Borkmann <daniel@...earbox.net>
Cc:     davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net] bpf: fix samples to add fake KBUILD_MODNAME

On Wed, Oct 26, 2016 at 09:01:48AM +0200, Daniel Borkmann wrote:
> On 10/26/2016 03:17 AM, Alexei Starovoitov wrote:
> >On Wed, Oct 26, 2016 at 12:37:53AM +0200, Daniel Borkmann wrote:
> >>Some of the sample files are causing issues when they are loaded with tc
> >>and cls_bpf, meaning tc bails out while trying to parse the resulting ELF
> >>file as program/map/etc sections are not present, which can be easily
> >>spotted with readelf(1).
> >>
> >>Currently, BPF samples are including some of the kernel headers and mid
> >>term we should change them to refrain from this, really. When dynamic
> >>debugging is enabled, we bail out due to undeclared KBUILD_MODNAME, which
> >>is easily overlooked in the build as clang spills this along with other
> >>noisy warnings from various header includes, and llc still generates an
> >>ELF file with mentioned characteristics. For just playing around with BPF
> >>examples, this can be a bit of a hurdle to take.
> >>
> >>Just add a fake KBUILD_MODNAME as a band-aid to fix the issue, same is
> >>done in xdp*_kern samples already.
> >>
> >>Fixes: 65d472fb007d ("samples/bpf: add 'pointer to packet' tests")
> >>Fixes: 6afb1e28b859 ("samples/bpf: Add tunnel set/get tests.")
> >>Fixes: a3f74617340b ("cgroup: bpf: Add an example to do cgroup checking in BPF")
> >>Reported-by: Chandrasekar Kannan <ckannan@...sole.to>
> >>Signed-off-by: Daniel Borkmann <daniel@...earbox.net>
> >>---
> >>  samples/bpf/parse_ldabs.c        | 1 +
> >>  samples/bpf/parse_simple.c       | 1 +
> >>  samples/bpf/parse_varlen.c       | 1 +
> >>  samples/bpf/tcbpf1_kern.c        | 1 +
> >>  samples/bpf/tcbpf2_kern.c        | 1 +
> >>  samples/bpf/test_cgrp2_tc_kern.c | 1 +
> >>  6 files changed, 6 insertions(+)
> >
> >It's also needed for all of tracex*_kern.c, right?
> 
> Rest compiles just fine for me and readelf output looks good on all
> tracex*_kern.o, too.
> 
> I see just warnings coming from various kernel header inclusions (see
> log), but no errors anymore.

ahh. good to know. I guess networking examples include some header
with dynamic debug that tracing examples don't.
Thanks for checking.

> ./include/linux/cgroup-defs.h:322:16: warning: field 'cgrp' with variable sized type 'struct cgroup' not at the end of a struct or class is a GNU extension [-Wgnu-variable-sized-type-not-at-end]
>         struct cgroup cgrp;
>                       ^
> 2 warnings generated.

this cgroup warning is crazy annoying and would have to be fixed anyway
for kernel to be compiled with clang.