netdev - Re: [PATCH iproute2 2/2] tc filters: fix filters to display handle when deleted even when no option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161026105749.1e366ef7@xeon-e3>
Date:   Wed, 26 Oct 2016 10:57:49 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Jamal Hadi Salim <jhs@...atatu.com>
Cc:     netdev@...r.kernel.org, daniel@...earbox.net,
        xiyou.wangcong@...il.com, mrv@...atatu.com
Subject: Re: [PATCH iproute2 2/2] tc filters: fix filters to display handle
 when deleted even when no option

On Mon, 17 Oct 2016 05:34:45 -0400
Jamal Hadi Salim <jhs@...atatu.com> wrote:

> From: Jamal Hadi Salim <jhs@...atatu.com>
> 
> Fix a few stylistic things that hurt my eyes while at it.
> 
> Signed-off-by: Jamal Hadi Salim <jhs@...atatu.com>

This patch has whitespace issues, please fix and resubmit.


ARNING: suspect code indent for conditional statements (16, 19)
#127: FILE: tc/f_fw.c:126:
+		if (tb[TCA_FW_MASK]) {
+		   __u32 tmask = rta_getattr_u32(tb[TCA_FW_MASK]);

WARNING: Statements should start on a tabstop
#131: FILE: tc/f_fw.c:129:
+		   if (tmask != 0xFFFFFFFF)

WARNING: suspect code indent for conditional statements (19, 27)
#131: FILE: tc/f_fw.c:129:
+		   if (tmask != 0xFFFFFFFF)
+			   mask = tmask;