netdev - Re: [PATCH net-next] sch_htb: do not report fake rate estimators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161026.171440.638427532009685965.davem@davemloft.net>
Date:   Wed, 26 Oct 2016 17:14:40 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org, jikos@...nel.org, jhs@...atatu.com
Subject: Re: [PATCH net-next] sch_htb: do not report fake rate estimators

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 21 Oct 2016 09:02:43 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> When I prepared commit d250a5f90e53 ("pkt_sched: gen_estimator: Dont
> report fake rate estimators"), htb still had an implicit rate estimator
> for all its classes.
> 
> Then later, I made this rate estimator optional in commit 64153ce0a7b6
> ("net_sched: htb: do not setup default rate estimators"), but I forgot
> to update htb use of gnet_stats_copy_rate_est()
> 
> After this patch, "tc -s qdisc ..." no longer report fake rate
> estimators for HTB classes.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks Eric.