netdev - Re: [PATCH v1 1/1] ISDN: eicon: replace custom hex_dump_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 26 Oct 2016 17:27:24 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     andriy.shevchenko@...ux.intel.com
Cc:     mac@...ware.de, netdev@...r.kernel.org, isdn@...ux-pingi.de
Subject: Re: [PATCH v1 1/1] ISDN: eicon: replace custom hex_dump_to_buffer()

From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Date: Sat, 22 Oct 2016 20:37:05 +0300

> Instead of custom approach re-use generic helper to convert bytes to hex
> format.
> 
> The output is slightly changed, namely string starts from the first dword
> value.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

This adds a warning.

Really, if you're not even going to check if the compiler warns
when you try to "clean up" such ancient drivers like this one,
don't even bother.

drivers/isdn/hardware/eicon/message.c: In function ‘dump_c_ind_mask’:
drivers/isdn/hardware/eicon/message.c:1156:22: warning: passing argument 1 of ‘hex_dump_to_buffer’ makes pointer from integer without a cast [-Wint-conversion]
   hex_dump_to_buffer(plci->c_ind_mask_table[i], j, 16, 4, buf, sizeof(buf), false);
                      ^~~~
In file included from ./include/linux/kernel.h:13:0,
                 from ./include/linux/list.h:8,
                 from ./include/linux/module.h:9,
                 from drivers/isdn/hardware/eicon/platform.h:21,
                 from drivers/isdn/hardware/eicon/message.c:30:
./include/linux/printk.h:457:12: note: expected ‘const void *’ but argument is of type ‘u32 {aka unsigned int}’
 extern int hex_dump_to_buffer(const void *buf, size_t len, int rowsize,
            ^~~~~~~~~~~~~~~~~~