netdev - Re: [PATCH net-next] netlink: Add nla_memdup() to wrap kmemdup() use on nlattr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1477472376.4059.23.camel@sipsolutions.net>
Date:   Wed, 26 Oct 2016 10:59:36 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     Thomas Graf <tgraf@...g.ch>, davem@...emloft.net
Cc:     daniel@...earbox.net, netdev@...r.kernel.org,
        linux-wireless@...r.kernel.org
Subject: Re: [PATCH net-next] netlink: Add nla_memdup() to wrap kmemdup()
 use on nlattr

>  /**
> + * nla_memdup - duplicate attribute memory (kmemdup)
> + * @src: netlink attribute to duplicate from
> + * @gfp: GFP mask

Actually, is there any point in passing a GFP mask? None of the current
users need it, and it seems fairly unlikely to be needed since this is
typically used on the netlink input path, where you surely shouldn't
need GFP_ATOMIC or so?

johannes