netdev - Re: [PATCH RDS v1] rds: debug messages are enabled by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 Oct 2016 09:01:02 -0700
From:   Wengang <wen.gang.wang@...cle.com>
To:     shamir.rabinovitch@...cle.com, netdev@...r.kernel.org
Cc:     santosh.shilimkar@...cle.com, davem@...emloft.net
Subject: Re: [PATCH RDS v1] rds: debug messages are enabled by default

Reviewed-by: Wengang Wang <wen.gang.wang@...cle.com>

thanks,

wengang


On 10/27/2016 2:46 AM, shamir.rabinovitch@...cle.com wrote:
> From: shamir rabinovitch <shamir.rabinovitch@...cle.com>
>
> rds use Kconfig option called "RDS_DEBUG" to enable rds debug messages.
> This option cause the rds Makefile to add -DDEBUG to the rds gcc command
> line.
>
> When CONFIG_DYNAMIC_DEBUG is enabled, the "DEBUG" macro is used by
> include/linux/dynamic_debug.h to decide if dynamic debug prints should
> be sent by default to the kernel log.
>
> rds should not enable this macro for production builds. rds dynamic
> debug work as expected follow this fix.
>
> Signed-off-by: Shamir Rabinovitch <shamir.rabinovitch@...cle.com>
> ---
>   net/rds/Makefile |    2 +-
>   net/rds/rds.h    |    2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/rds/Makefile b/net/rds/Makefile
> index 0e72bec..56c7d27 100644
> --- a/net/rds/Makefile
> +++ b/net/rds/Makefile
> @@ -13,5 +13,5 @@ obj-$(CONFIG_RDS_TCP) += rds_tcp.o
>   rds_tcp-y :=		tcp.o tcp_connect.o tcp_listen.o tcp_recv.o \
>   			tcp_send.o tcp_stats.o
>   
> -ccflags-$(CONFIG_RDS_DEBUG)	:=	-DDEBUG
> +ccflags-$(CONFIG_RDS_DEBUG)	:=	-DRDS_DEBUG
>   
> diff --git a/net/rds/rds.h b/net/rds/rds.h
> index 25532a4..4121e18 100644
> --- a/net/rds/rds.h
> +++ b/net/rds/rds.h
> @@ -33,7 +33,7 @@
>   #define KERNEL_HAS_ATOMIC64
>   #endif
>   
> -#ifdef DEBUG
> +#ifdef RDS_DEBUG
>   #define rdsdebug(fmt, args...) pr_debug("%s(): " fmt, __func__ , ##args)
>   #else
>   /* sigh, pr_debug() causes unused variable warnings */