netdev - Re: [PATCH net] netvsc: fix incorrect receive checksum offloading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161026.231942.1795915733192661471.davem@davemloft.net>
Date:   Wed, 26 Oct 2016 23:19:42 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     stephen@...workplumber.org
Cc:     kys@...rosoft.com, haiyangz@...rosoft.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] netvsc: fix incorrect receive checksum offloading

From: Stephen Hemminger <stephen@...workplumber.org>
Date: Sun, 23 Oct 2016 21:32:47 -0700

> From: Stephen Hemminger <sthemmin@...rosoft.com>
> 
> The Hyper-V netvsc driver was looking at the incorrect status bits
> in the checksum info. It was setting the receive checksum unnecessary
> flag based on the IP header checksum being correct. The checksum
> flag is skb is about TCP and UDP checksum status. Because of this
> bug, any packet received with bad TCP checksum would be passed
> up the stack and to the application causing data corruption.
> The problem is reproducible via netcat and netem.
> 
> This had a side effect of not doing receive checksum offload
> on IPv6. The driver was also also always doing checksum offload
> independent of the checksum setting done via ethtool.
> 
> Signed-off-by: Stephen Hemminger <sthemmin@...rosoft.com>

Applied and queued up for -stable.