netdev - RE: [bnx2] [Regression 4.8] Driver loading fails without firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BLUPR0701MB1572F3F88329B109F2A6C29C9FAA0@BLUPR0701MB1572.namprd07.prod.outlook.com>
Date:   Thu, 27 Oct 2016 18:16:56 +0000
From:   "Mody, Rasesh" <Rasesh.Mody@...ium.com>
To:     Paul Menzel <pmenzel@...gen.mpg.de>, Baoquan He <bhe@...hat.com>
CC:     "dvteam@...gen.mpg.de" <dvteam@...gen.mpg.de>,
        "Dept-HSGLinuxNICDev@...gic.com" <Dept-HSGLinuxNICDev@...gic.com>,
        "David S. Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [bnx2] [Regression 4.8] Driver loading fails without firmware

> From: dept_hsg_linux_nic_dev-bounces@...listserver.qlogic.com
> [mailto:dept_hsg_linux_nic_dev-bounces@...listserver.qlogic.com] On
> Behalf Of Paul Menzel
> 
> Dear Baoquan,
> 
> 
> On 10/26/16 14:00, Baoquan He wrote:
> 
> > On 10/26/16 at 12:31pm, Paul Menzel wrote:
> >>>>         dev->hw_features = NETIF_F_IP_CSUM | NETIF_F_SG | @@
> >>>> -8607,6 +8608,7 @@ bnx2_init_one(struct pci_dev *pdev, const struct
> >>>> pci_device_id *ent)
> >>>>         return 0;
> >>>>
> >>>>  error:
> >>>> +       bnx2_release_firmware(bp);
> >>>>         pci_iounmap(pdev, bp->regview);
> >>>>         pci_release_regions(pdev);
> >>>>         pci_disable_device(pdev);
> >>
> >> Baoquan, could you please fix this regression. My suggestion is, that
> >> you add the old code back, but check if the firmware has been loaded.
> >> If it hasn’t, load it again.
> >>
> >> That way, people can update their Linux kernel, and it continues
> >> working without changing the initramfs, or anything else.
> >
> > I saw your mail but I am also not familiar with bnx2 driver. As the
> > commit log says I just tried to make bnx2 driver reset itself earlier.
> >
> > So you did a git bisect and found this commit caused the regression,
> > right? If yes, and network developers have no action, I will look into
> > the code and see if I have idea to fix it.
> 
> Well, I looked through the commits and found that one, which would explain
> the changed behavior.
> 
> To be sure, and to follow your request, I took Linux 4.8.4 and reverted your
> commit (attached). Then I deleted the firmware again from the initramfs,
> and rebooted. The devices showed up just fine as before.

Thanks Paul!
Acked-by: Rasesh Mody <Rasesh.Mody@...ium.com>

> So to summarize, the commit is indeed the culprit.
> 
> Thank you for looking into this.
> 
> 
> Kind regards,
> 
> Paul