netdev - Re: [patch net-next] rocker: set physical device for port netdevice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201610280406.ryplT5DV%fengguang.wu@intel.com>
Date:   Fri, 28 Oct 2016 04:04:07 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     kbuild-all@...org, netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [patch net-next] rocker: set physical device for port netdevice

Hi Jiri,

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Jiri-Pirko/rocker-set-physical-device-for-port-netdevice/20161028-030044
config: xtensa-allmodconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 4.9.0
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=xtensa 

All warnings (new ones prefixed by >>):

   In file included from drivers/net/ethernet/rocker/rocker_main.c:21:0:
   drivers/net/ethernet/rocker/rocker_main.c: In function 'rocker_probe_port':
>> include/linux/netdevice.h:2062:54: warning: assignment discards 'const' qualifier from pointer target type
    #define SET_NETDEV_DEV(net, pdev) ((net)->dev.parent = (pdev))
                                                         ^
>> drivers/net/ethernet/rocker/rocker_main.c:2545:2: note: in expansion of macro 'SET_NETDEV_DEV'
     SET_NETDEV_DEV(dev, &pdev->dev);
     ^

vim +/SET_NETDEV_DEV +2545 drivers/net/ethernet/rocker/rocker_main.c

  2529			eth_hw_addr_random(rocker_port->dev);
  2530		}
  2531	}
  2532	
  2533	#define ROCKER_PORT_MIN_MTU	ETH_MIN_MTU
  2534	#define ROCKER_PORT_MAX_MTU	9000
  2535	static int rocker_probe_port(struct rocker *rocker, unsigned int port_number)
  2536	{
  2537		const struct pci_dev *pdev = rocker->pdev;
  2538		struct rocker_port *rocker_port;
  2539		struct net_device *dev;
  2540		int err;
  2541	
  2542		dev = alloc_etherdev(sizeof(struct rocker_port));
  2543		if (!dev)
  2544			return -ENOMEM;
> 2545		SET_NETDEV_DEV(dev, &pdev->dev);
  2546		rocker_port = netdev_priv(dev);
  2547		rocker_port->dev = dev;
  2548		rocker_port->rocker = rocker;
  2549		rocker_port->port_number = port_number;
  2550		rocker_port->pport = port_number + 1;
  2551	
  2552		err = rocker_world_check_init(rocker_port);
  2553		if (err) {

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (47036 bytes)