netdev - Re: [PATCH v2 net] macsec: Fix header length if SCI is added if explicitly disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161027.162153.2102538919251888970.davem@davemloft.net>
Date:   Thu, 27 Oct 2016 16:21:53 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     tobias@...ongswan.org
Cc:     sd@...asysnail.net, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net] macsec: Fix header length if SCI is added if
 explicitly disabled

From: Tobias Brunner <tobias@...ongswan.org>
Date: Mon, 24 Oct 2016 15:44:26 +0200

> Even if sending SCIs is explicitly disabled, the code that creates the
> Security Tag might still decide to add it (e.g. if multiple RX SCs are
> defined on the MACsec interface).
> But because the header length so far only depended on the configuration
> option the SCI overwrote the original frame's contents (EtherType and
> e.g. the beginning of the IP header) and if encrypted did not visibly
> end up in the packet, while the SC flag in the TCI field of the Security
> Tag was still set, resulting in invalid MACsec frames.
> 
> Fixes: c09440f7dcb3 ("macsec: introduce IEEE 802.1AE driver")
> Signed-off-by: Tobias Brunner <tobias@...ongswan.org>

Applied and queued up for -stable.