netdev - Re: [PATCH v2] net: skip genenerating uevents for network namespaces that are exiting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161027.171521.641636732714679018.davem@davemloft.net>
Date:   Thu, 27 Oct 2016 17:15:21 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     avagin@...nvz.org
Cc:     ebiederm@...ssion.com, containers@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        xiyou.wangcong@...il.com
Subject: Re: [PATCH v2] net: skip genenerating uevents for network
 namespaces that are exiting

From: Andrei Vagin <avagin@...nvz.org>
Date: Mon, 24 Oct 2016 19:09:53 -0700

> No one can see these events, because a network namespace can not be
> destroyed, if it has sockets.
> 
> Unlike other devices, uevent-s for network devices are generated
> only inside their network namespaces. They are filtered in
> kobj_bcast_filter()
> 
> My experiments shows that net namespaces are destroyed more 30% faster
> with this optimization.
> 
> Here is a perf output for destroying network namespaces without this
> patch.
 ...
> It's very critical to optimize the exit path for network namespaces,
> because they are destroyed under net_mutex and many namespaces can be
> destroyed for one iteration.
> 
> v2: use dev_set_uevent_suppress()
> 
> Cc: Cong Wang <xiyou.wangcong@...il.com>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Eric W. Biederman <ebiederm@...ssion.com>
> Signed-off-by: Andrei Vagin <avagin@...nvz.org>

Applied to net-next, thanks.