netdev - Re: [PATCH net 1/2] vxlan: avoid using stale vxlan socket.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161027160219.06a946f4@xeon-e3>
Date:   Thu, 27 Oct 2016 16:02:19 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Pravin B Shelar <pshelar@....org>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net 1/2] vxlan: avoid using stale vxlan socket.

On Thu, 27 Oct 2016 11:51:55 -0700
Pravin B Shelar <pshelar@....org> wrote:

> -	vxlan->vn4_sock = NULL;
> +	rcu_assign_pointer(vxlan->vn4_sock, NULL);
>  #if IS_ENABLED(CONFIG_IPV6)
> -	vxlan->vn6_sock = NULL;
> +	rcu_assign_pointer(vxlan->vn6_sock, NULL);
>  	if (ipv6 || metadata)

User RCU_INIT_POINTER when setting pointer to NULL.
It avoids unnecessary barrier.