netdev - Re: [patch net-next 3/5] mlxsw: Move PCI id table definitions into driver modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2df03fe8-8f7a-f6af-6894-54e07f61a962@redhat.com>
Date:   Thu, 27 Oct 2016 16:39:23 +0200
From:   Ivan Vecera <ivecera@...hat.com>
To:     Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, idosch@...lanox.com, eladr@...lanox.com,
        yotamg@...lanox.com, nogahf@...lanox.com, ogerlitz@...lanox.com
Subject: Re: [patch net-next 3/5] mlxsw: Move PCI id table definitions into
 driver modules

Dne 27.10.2016 v 15:12 Jiri Pirko napsal(a):
> From: Jiri Pirko <jiri@...lanox.com>
>
> So far, mlxsw_pci.ko is the module that registers PCI table for all
> drivers (spectrum and switchx2). That is problematic for example with
> dracut. Since mlxsw_spectrum.ko and mlxsw_switchx2.ko are loaded
> dynamically from within mlxsw_core.ko, dracut does not have track of
> them and avoids them from being included in initramfs.
>
> So make this in an ordinary way and define the PCI tables in individual
> driver modules, so it can be properly loaded and included in dracut
> initramfs image. As a side effect, this patch could remove no longer
> necessary driver "kind" strings which were used to link PCI ids with
> individual mlxsw drivers.
>
> Suggested-by: Ivan Vecera <ivecera@...hat.com>
> Tested-by: Ivan Vecera <ivecera@...hat.com>
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>
> Reviewed-by: Ido Schimmel <idosch@...lanox.com>
Thanks Jiri.

Acked-by: Ivan Vecera <ivecera@...hat.com>