netdev - Re: [PATCH net-next v1 04/16] tipc: rename struct tipc_skb_cb member handle to bytes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161029.170120.1383330491683606210.davem@davemloft.net>
Date:   Sat, 29 Oct 2016 17:01:20 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     parthasarathy.bhuvaragan@...csson.com
Cc:     netdev@...r.kernel.org, tipc-discussion@...ts.sourceforge.net,
        jon.maloy@...csson.com, maloy@...jonn.com, ying.xue@...driver.com
Subject: Re: [PATCH net-next v1 04/16] tipc: rename struct tipc_skb_cb
 member handle to bytes_read

From: Parthasarathy Bhuvaragan <parthasarathy.bhuvaragan@...csson.com>
Date: Thu, 27 Oct 2016 16:22:25 +0200

> @@ -95,7 +95,7 @@ struct plist;
>  #define TIPC_MEDIA_INFO_OFFSET	5
>  
>  struct tipc_skb_cb {
> -	void *handle;
> +	u32 bytes_read;
>  	struct sk_buff *tail;
>  	bool validated;
>  	bool wakeup_pending;

If this is now a u32, then:

> -		u32 offset = (u32)(unsigned long)(TIPC_SKB_CB(buf)->handle);
> +		u32 offset = (u32)(TIPC_SKB_CB(buf)->bytes_read);

This cast is unnecessary as are the parenthesis.