netdev - Re: [PATCH net-next] bpf: Print function name in addition to function id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161029.155608.910725512368974977.davem@davemloft.net>
Date:   Sat, 29 Oct 2016 15:56:08 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     tgraf@...g.ch
Cc:     netdev@...r.kernel.org, daniel@...earbox.net, ast@...nel.org
Subject: Re: [PATCH net-next] bpf: Print function name in addition to
 function id

From: Thomas Graf <tgraf@...g.ch>
Date: Thu, 27 Oct 2016 11:23:51 +0200

> The verifier currently prints raw function ids when printing CALL
> instructions or when complaining:
> 
> 	5: (85) call 23
> 	unknown func 23
> 
> print a meaningful function name instead:
> 
> 	5: (85) call bpf_redirect#23
> 	unknown func bpf_redirect#23
> 
> Moves the function documentation to a single comment and renames all
> helpers names in the list to conform to the bpf_ prefix notation so
> they can be greped in the kernel source.
> 
> Signed-off-by: Thomas Graf <tgraf@...g.ch>
> Acked-by: Daniel Borkmann <daniel@...earbox.net>
> Acked-by: Alexei Starovoitov <ast@...nel.org>

Applied.