netdev - Re: [PATCH net] qede: Fix out-of-bound fastpath memory access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161029.205211.335465842143257419.davem@davemloft.net>
Date:   Sat, 29 Oct 2016 20:52:11 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     Yuval.Mintz@...ium.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] qede: Fix out-of-bound fastpath memory access

From: Yuval Mintz <Yuval.Mintz@...ium.com>
Date: Sat, 29 Oct 2016 17:04:35 +0300

> Driver allocates a shadow array for transmitted SKBs with X entries;
> That means valid indices are {0,...,X - 1}. [X == 8191]
> Problem is the driver also uses X as a mask for a
> producer/consumer in order to choose the right entry in the
> array which allows access to entry X which is out of bounds.
> 
> To fix this, simply allocate X + 1 entries in the shadow array.
> 
> Signed-off-by: Yuval Mintz <Yuval.Mintz@...ium.com>

Applied.