lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 31 Oct 2016 01:21:18 +0200
From:   Saeed Mahameed <>
To:     Alexei Starovoitov <>
Cc:     Tariq Toukan <>,
        Tariq Toukan <>,
        "David S. Miller" <>,
        Linux Netdev List <>,
        Eran Ben Elisha <>,
        Brenden Blanco <>
Subject: Re: [PATCH net-next 2/2] net/mlx4_en: Refactor the XDP forwarding
 rings scheme

On Mon, Oct 31, 2016 at 1:11 AM, Saeed Mahameed
<> wrote:
> On Mon, Oct 31, 2016 at 12:44 AM, Alexei Starovoitov
> <> wrote:
>> On Sun, Oct 30, 2016 at 06:03:06PM +0200, Tariq Toukan wrote:
>>> Note that the XDP TX rings are no longer shown in ethtool -S.
>> ouch. Can you make it to show them as some large TX numbers instead?
>> It would really sux to lose stats on them.
> Right, Tariq, how did we miss this ?
> FYI, I don't think we need the whole TX queue stats for XDP tx rings,
> it is just an overkill, there are only two active counters for XDP TX
> XDP_TX_FWD or currently "tx_packets" will count successfully forwarded packets
> XDP_TX_DROP or currently "tx_dropped" will count TX dropped packets
> due to full ring.
> do we need tx_bytes as well ? I think yes.
> The whole idea of this refactoring i.e. differentiating between TXQ
> netdev rings and XDP TX rings, that XDP is a fast path with minimal
> system overhead, we don't need to have the full set of regular TXQ
> counters for XDP TX rings.

BTW in mlx5 we have the required xdp stats as a part of the rx ring,

static const struct counter_desc rq_stats_desc[] = {
{ MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, xdp_drop) },
{ MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, xdp_tx) },
{ MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, xdp_tx_full) },

We should do the same here.

Powered by blists - more mailing lists