netdev - Re: [PATCH v2 net-next 1/5] bpf: Refactor cgroups code in prep for new type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <542e0d3e-2f57-96f9-1da1-b71e2c970395@zonque.org>
Date:   Mon, 31 Oct 2016 18:00:21 +0100
From:   Daniel Mack <daniel@...que.org>
To:     David Miller <davem@...emloft.net>, dsa@...ulusnetworks.com
Cc:     netdev@...r.kernel.org, ast@...com, daniel@...earbox.net,
        maheshb@...gle.com, tgraf@...g.ch
Subject: Re: [PATCH v2 net-next 1/5] bpf: Refactor cgroups code in prep for
 new type

On 10/31/2016 05:58 PM, David Miller wrote:
> From: David Ahern <dsa@...ulusnetworks.com>
> Date: Wed, 26 Oct 2016 17:58:38 -0700
> 
>> diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
>> index 6b62ee9a2f78..73da296c2125 100644
>> --- a/include/uapi/linux/bpf.h
>> +++ b/include/uapi/linux/bpf.h
>> @@ -98,7 +98,7 @@ enum bpf_prog_type {
>>  	BPF_PROG_TYPE_TRACEPOINT,
>>  	BPF_PROG_TYPE_XDP,
>>  	BPF_PROG_TYPE_PERF_EVENT,
>> -	BPF_PROG_TYPE_CGROUP_SKB,
>> +	BPF_PROG_TYPE_CGROUP,
>>  };
>>  
>>  enum bpf_attach_type {
> 
> If we do this then the cgroup-bpf series should use this value rather than
> changing it after-the-fact in your series here.
> 

Yeah, I'm confused too. I changed that name in my v7 from
BPF_PROG_TYPE_CGROUP_SOCK to BPF_PROG_TYPE_CGROUP_SKB on David's (Ahern)
request. Why is it now renamed again?


Thanks,
Daniel