netdev - Re: [PATCH net-next v3]ldmvsw: tx queue stuck in stopped state after LDC reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 31 Oct 2016 15:20:49 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     Aaron.Young@...cle.com
Cc:     netdev@...r.kernel.org, sowmini.varadhan@...cle.com
Subject: Re: [PATCH net-next v3]ldmvsw: tx queue stuck in stopped state
 after LDC reset 

From: Aaron Young <Aaron.Young@...cle.com>
Date: Fri, 28 Oct 2016 14:26:19 -0400

> From: Aaron Young <aaron.young@...cle.com>
> 
> The following patch fixes an issue with the ldmvsw driver where
> the network connection of a guest domain becomes non-functional after
> the guest domain has panic'd and rebooted.
> 
> The root cause was determined to be from the following series of
> events:
> 
> 1. Guest domain panics - resulting in the guest no longer processing
>    network packets (from ldmvsw driver)
> 2. The ldmvsw driver (in the control domain) eventually exerts flow
>    control due to no more available tx drings and stops the tx queue
>    for the guest domain
> 3. The LDC of the network connection for the guest is reset when
>    the guest domain reboots after the panic.
> 4. The LDC reset event is received by the ldmvsw driver and the ldmvsw
>    responds by clearing the tx queue for the guest.
> 5. ldmvsw waits indefinitely for a DATA ACK from the guest - which is
>    the normal method to re-enable the tx queue. But the ACK never comes
>    because the tx queue was cleared due to the LDC reset.
> 
> To fix this issue, in addition to clearing the tx queue, re-enable the
> tx queue on a LDC reset. This prevents the ldmvsw from getting caught in
> this deadlocked state of waiting for a DATA ACK which will never come.
> 
> Signed-off-by: Aaron Young <Aaron.Young@...cle.com>
> Acked-by: Sowmini Varadhan <sowmini.varadhan@...cle.com>

Applied, thank you.