netdev - Re: [patch net] mlxsw: spectrum: Fix incorrect reuse of MID entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20161031.153606.989406936490082438.davem@davemloft.net>
Date:   Mon, 31 Oct 2016 15:36:06 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     jiri@...nulli.us
Cc:     netdev@...r.kernel.org, eladr@...lanox.com, idosch@...lanox.com,
        yotamg@...lanox.com, nogahf@...lanox.com, ogerlitz@...lanox.com
Subject: Re: [patch net] mlxsw: spectrum: Fix incorrect reuse of MID entries

From: Jiri Pirko <jiri@...nulli.us>
Date: Sun, 30 Oct 2016 10:09:22 +0100

> From: Ido Schimmel <idosch@...lanox.com>
> 
> In the device, a MID entry represents a group of local ports, which can
> later be bound to a MDB entry.
> 
> The lookup of an existing MID entry is currently done using the provided
> MC MAC address and VID, from the Linux bridge. However, this can result
> in an incorrect reuse of the same MID index in different VLAN-unaware
> bridges (same IP MC group and VID 0).
> 
> Fix this by performing the lookup based on FID instead of VID, which is
> unique across different bridges.
> 
> Fixes: 3a49b4fde2a1 ("mlxsw: Adding layer 2 multicast support")
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>
> Acked-by: Elad Raz <eladr@...lanox.com>
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>

Applied, should I queue this up for -stable?