netdev - Re: [PATCH net-next] ipv4: fib: Replay events when registering FIB notifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 31 Oct 2016 11:03:37 +0200
From:   Ido Schimmel <idosch@...sch.org>
To:     kbuild test robot <lkp@...el.com>
Cc:     kbuild-all@...org, netdev@...r.kernel.org, davem@...emloft.net,
        jiri@...lanox.com, mlxsw@...lanox.com, roopa@...ulusnetworks.com,
        nikolay@...ulusnetworks.com, dsa@...ulusnetworks.com,
        andy@...yhouse.net, alexander.h.duyck@...el.com,
        vivien.didelot@...oirfairelinux.com, f.fainelli@...il.com,
        andrew@...n.ch, kuznet@....inr.ac.ru, jmorris@...ei.org,
        yoshfuji@...ux-ipv6.org, kaber@...sh.net,
        Ido Schimmel <idosch@...lanox.com>
Subject: Re: [PATCH net-next] ipv4: fib: Replay events when registering FIB
 notifier

On Tue, Nov 01, 2016 at 12:54:01AM +0800, kbuild test robot wrote:
> Hi Ido,
> 
> [auto build test ERROR on net-next/master]
> 
> url:    https://github.com/0day-ci/linux/commits/idosch-idosch-org/ipv4-fib-Replay-events-when-registering-FIB-notifier/20161031-163334
> config: x86_64-randconfig-x014-201644 (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=x86_64 
> 
> All errors (new ones prefixed by >>):
> 
>    net/ipv4/fib_trie.c: In function 'register_fib_notifier':
> >> net/ipv4/fib_trie.c:141:16: error: 'struct netns_ipv4' has no member named 'fib_has_custom_rules'
>       if (net->ipv4.fib_has_custom_rules)
>                    ^
>    net/ipv4/fib_trie.c: In function 'unregister_fib_notifier':
>    net/ipv4/fib_trie.c:178:16: error: 'struct netns_ipv4' has no member named 'fib_has_custom_rules'
>       if (net->ipv4.fib_has_custom_rules)
>                    ^

Right, I missed that. Will send a v2.

Thanks!

> 
> vim +141 net/ipv4/fib_trie.c
> 
>    135		err = blocking_notifier_chain_register(&fib_chain, nb);
>    136		if (err)
>    137			goto unlock;
>    138		for_each_net(net) {
>    139			struct fib_notifier_info info;
>    140	
>  > 141			if (net->ipv4.fib_has_custom_rules)
>    142				call_fib_notifier(nb, net, FIB_EVENT_RULE_ADD, &info);
>    143			fib_notify(net, nb, FIB_EVENT_ENTRY_ADD);
>    144		}
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation