netdev - Re: [PATCH net-next v2 1/1] driver: tun: Use new macro SOCK_IOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161031.105734.1090205624340098305.davem@davemloft.net>
Date:   Mon, 31 Oct 2016 10:57:34 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     fgao@...ai8.com
Cc:     jasowang@...hat.com, edumazet@...gle.com, pabeni@...hat.com,
        netdev@...r.kernel.org, gfree.wind@...il.com
Subject: Re: [PATCH net-next v2 1/1] driver: tun: Use new macro
 SOCK_IOC_TYPE instead of literal number 0x89

From: fgao@...ai8.com
Date: Thu, 27 Oct 2016 09:05:22 +0800

> From: Gao Feng <fgao@...ai8.com>
> 
> The current codes use _IOC_TYPE(cmd) == 0x89 to check if the cmd is one
> socket ioctl command like SIOCGIFHWADDR. But the literal number 0x89 may
> confuse readers. So create one macro SOCK_IOC_TYPE to enhance the readability.
> 
> Signed-off-by: Gao Feng <fgao@...ai8.com>

Applied.