netdev - Re: [PATCH net-next] mlxsw: switchib: Remove unused including <generated/utsrelease.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161101154449.GC1677@nanopsycho.orion>
Date:   Tue, 1 Nov 2016 16:44:49 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Wei Yongjun <weiyj.lk@...il.com>
Cc:     Jiri Pirko <jiri@...lanox.com>, Ido Schimmel <idosch@...lanox.com>,
        Wei Yongjun <weiyongjun1@...wei.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] mlxsw: switchib: Remove unused including
 <generated/utsrelease.h>

Tue, Nov 01, 2016 at 04:14:08PM CET, weiyj.lk@...il.com wrote:
>From: Wei Yongjun <weiyongjun1@...wei.com>
>
>Remove including <generated/utsrelease.h> that don't need it.
>
>Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
>---
> drivers/net/ethernet/mellanox/mlxsw/switchib.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/drivers/net/ethernet/mellanox/mlxsw/switchib.c b/drivers/net/ethernet/mellanox/mlxsw/switchib.c
>index ec0b27e..1552594 100644
>--- a/drivers/net/ethernet/mellanox/mlxsw/switchib.c
>+++ b/drivers/net/ethernet/mellanox/mlxsw/switchib.c
>@@ -43,7 +43,6 @@
> #include <linux/skbuff.h>
> #include <linux/if_vlan.h>
> #include <net/switchdev.h>
>-#include <generated/utsrelease.h>

I believe it is not needed so spectrum.c and switchx2.x. Would you
please extend your patch to remove from there as well? Thanks.