netdev - Re: [PATCH net-next v2] genetlink: fix error return code in genl_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161101.121351.1287443789684060786.davem@davemloft.net>
Date:   Tue, 01 Nov 2016 12:13:51 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     weiyj.lk@...il.com
Cc:     stephen@...workplumber.org, tom@...bertland.com, fw@...len.de,
        johannes.berg@...el.com, pshelar@....org,
        tycho.andersen@...onical.com, matti.vaittinen@...ia.com,
        weiyongjun1@...wei.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2] genetlink: fix error return code in
 genl_register_family()

From: Wei Yongjun <weiyj.lk@...il.com>
Date: Tue,  1 Nov 2016 14:45:52 +0000

> From: Wei Yongjun <weiyongjun1@...wei.com>
> 
> Fix to return a negative error code from the idr_alloc() error handling
> case instead of 0, as done elsewhere in this function.
> 
> Also fix the return value check of idr_alloc() since idr_alloc return
> negative errors on failure, not zero.
> 
> Fixes: 2ae0f17df1cd ("genetlink: use idr to track families")
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---
> v1 -> v2: fix the return value check and return idr_alloc's err code

Applied, thanks.