netdev - Re: [PATCH net-next] tcp: enhance tcp collapsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1478022467.7065.347.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Tue, 01 Nov 2016 10:47:47 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Neal Cardwell <ncardwell@...gle.com>
Cc:     Ilya Lesokhin <ilyal@...lanox.com>,
        David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>,
        Yuchung Cheng <ycheng@...gle.com>
Subject: Re: [PATCH net-next] tcp: enhance tcp collapsing

On Tue, 2016-11-01 at 10:39 -0700, Eric Dumazet wrote:

> Thanks Neal.
> 
> David please hold this patch, further tests show an issue I need to
> track and fix.

The issue is that the right skb can be a FIN packet with no data,
merged to a left skb with frag(s).

Thus I need to call skb_copy_bits() only if there is something to copy,
otherwise skb_put() can BUG_ON in SKB_LINEAR_ASSERT(), even if @len is
0.