netdev - Re: [PATCHv2 net 0/3] sctp: a bunch of fixes by holding transport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161101133234.GA10666@hmsreliant.think-freely.org>
Date:   Tue, 1 Nov 2016 09:32:34 -0400
From:   Neil Horman <nhorman@...driver.com>
To:     Xin Long <lucien.xin@...il.com>
Cc:     network dev <netdev@...r.kernel.org>, linux-sctp@...r.kernel.org,
        davem@...emloft.net,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
        Vlad Yasevich <vyasevich@...il.com>
Subject: Re: [PATCHv2 net 0/3] sctp: a bunch of fixes by holding transport

On Mon, Oct 31, 2016 at 08:32:30PM +0800, Xin Long wrote:
> There are several places where it holds assoc after getting transport by
> searching from transport rhashtable, it may cause use-after-free issue.
> 
> This patchset is to fix them by holding transport instead.
> 
> v1->v2:
>   Fix the changelog of patch 2/3
> 
> Xin Long (3):
>   sctp: hold transport instead of assoc in sctp_diag
>   sctp: return back transport in __sctp_rcv_init_lookup
>   sctp: hold transport instead of assoc when lookup assoc in rx path
> 
>  include/net/sctp/sctp.h |  2 +-
>  net/sctp/input.c        | 35 +++++++++++++++++------------------
>  net/sctp/ipv6.c         |  2 +-
>  net/sctp/socket.c       |  5 +----
>  4 files changed, 20 insertions(+), 24 deletions(-)
> 
> -- 
> 2.1.0
> 
> 
series
Acked-by: Neil Horman <nhorman@...driver.com>