netdev - Re: [PATCH net-next] enic: set skb->hash type properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161102.153311.601230263396468572.davem@davemloft.net>
Date:   Wed, 02 Nov 2016 15:33:11 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     gvaradar@...co.com
Cc:     benve@...co.com, netdev@...r.kernel.org, _govind@....com
Subject: Re: [PATCH net-next] enic: set skb->hash type properly

From: Govindarajulu Varadarajan <gvaradar@...co.com>
Date: Tue,  1 Nov 2016 17:58:50 -0700

> From: Govindarajulu Varadarajan <_govind@....com>
> 
> Driver sets the skb l4/l3 hash based on NIC_CFG_RSS_HASH_TYPE_*,
> which is bit mask. This is wrong. Hw actually provides us enum.
> Use CQ_ENET_RQ_DESC_RSS_TYPE_* to set l3 and l4 hash type.
> 
> Fixes: bf751ba802fe ("driver/net: enic: record q_number and rss_hash for skb")
> Signed-off-by: Govindarajulu Varadarajan <_govind@....com>

Applied, thanks.