netdev - Re: [PATCH net v2] ipv4: allow local fragmentation in ip_finish_output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201611030402.uXe8L1gG%fengguang.wu@intel.com>
Date:   Thu, 3 Nov 2016 04:20:01 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Lance Richardson <lrichard@...hat.com>
Cc:     kbuild-all@...org, netdev@...r.kernel.org, fw@...len.de,
        jtluka@...hat.com, hannes@...essinduktion.org
Subject: Re: [PATCH net v2] ipv4: allow local fragmentation in
 ip_finish_output_gso()

Hi Lance,

[auto build test WARNING on net/master]

url:    https://github.com/0day-ci/linux/commits/Lance-Richardson/ipv4-allow-local-fragmentation-in-ip_finish_output_gso/20161103-040904
config: x86_64-randconfig-x014-201644 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   net/ipv4/ip_tunnel_core.c: In function 'iptunnel_xmit':
>> net/ipv4/ip_tunnel_core.c:66:6: warning: unused variable 'skb_iif' [-Wunused-variable]
     int skb_iif = skb->skb_iif;
         ^~~~~~~

vim +/skb_iif +66 net/ipv4/ip_tunnel_core.c

0e6fbc5b6 Pravin B Shelar   2013-06-17  50  
55c2bc143 Tom Herbert       2016-05-18  51  const struct ip_tunnel_encap_ops __rcu *
55c2bc143 Tom Herbert       2016-05-18  52  		iptun_encaps[MAX_IPTUN_ENCAP_OPS] __read_mostly;
55c2bc143 Tom Herbert       2016-05-18  53  EXPORT_SYMBOL(iptun_encaps);
55c2bc143 Tom Herbert       2016-05-18  54  
058214a4d Tom Herbert       2016-05-18  55  const struct ip6_tnl_encap_ops __rcu *
058214a4d Tom Herbert       2016-05-18  56  		ip6tun_encaps[MAX_IPTUN_ENCAP_OPS] __read_mostly;
058214a4d Tom Herbert       2016-05-18  57  EXPORT_SYMBOL(ip6tun_encaps);
058214a4d Tom Herbert       2016-05-18  58  
039f50629 Pravin B Shelar   2015-12-24  59  void iptunnel_xmit(struct sock *sk, struct rtable *rt, struct sk_buff *skb,
0e6fbc5b6 Pravin B Shelar   2013-06-17  60  		   __be32 src, __be32 dst, __u8 proto,
963a88b31 Nicolas Dichtel   2013-09-02  61  		   __u8 tos, __u8 ttl, __be16 df, bool xnet)
0e6fbc5b6 Pravin B Shelar   2013-06-17  62  {
bc22a0e2e Nicolas Dichtel   2015-09-18  63  	int pkt_len = skb->len - skb_inner_network_offset(skb);
f859b0f66 Eric W. Biederman 2015-10-07  64  	struct net *net = dev_net(rt->dst.dev);
039f50629 Pravin B Shelar   2015-12-24  65  	struct net_device *dev = skb->dev;
b8247f095 Shmulik Ladkani   2016-07-18 @66  	int skb_iif = skb->skb_iif;
0e6fbc5b6 Pravin B Shelar   2013-06-17  67  	struct iphdr *iph;
0e6fbc5b6 Pravin B Shelar   2013-06-17  68  	int err;
0e6fbc5b6 Pravin B Shelar   2013-06-17  69  
963a88b31 Nicolas Dichtel   2013-09-02  70  	skb_scrub_packet(skb, xnet);
963a88b31 Nicolas Dichtel   2013-09-02  71  
bf8d85d4f Eric Dumazet      2016-09-08  72  	skb_clear_hash_if_not_l4(skb);
0e6fbc5b6 Pravin B Shelar   2013-06-17  73  	skb_dst_set(skb, &rt->dst);
0e6fbc5b6 Pravin B Shelar   2013-06-17  74  	memset(IPCB(skb), 0, sizeof(*IPCB(skb)));

:::::: The code at line 66 was first introduced by commit
:::::: b8247f095eddfbfdba0fcecd1e3525a6cdb4b585 net: ip_finish_output_gso: If skb_gso_network_seglen exceeds MTU, allow segmentation for local udp tunneled skbs

:::::: TO: Shmulik Ladkani <shmulik.ladkani@...il.com>
:::::: CC: David S. Miller <davem@...emloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (33925 bytes)