netdev - Re: [PATCH net-next V2 3/3] net/mlx4_en: Add ethtool statistics for XDP cases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f09f2f20-460c-4cd1-3a7b-bba5b9819806@gmail.com>
Date:   Wed, 2 Nov 2016 10:18:21 +0200
From:   Tariq Toukan <ttoukan.linux@...il.com>
To:     Brenden Blanco <bblanco@...mgrid.com>,
        Tariq Toukan <tariqt@...lanox.com>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Eran Ben Elisha <eranbe@...lanox.com>,
        Alexei Starovoitov <alexei.starovoitov@...il.com>,
        Saeed Mahameed <saeedm@...lanox.com>
Subject: Re: [PATCH net-next V2 3/3] net/mlx4_en: Add ethtool statistics for
 XDP cases

Hi Brenden,

On 01/11/2016 11:06 PM, Brenden Blanco wrote:
> On Tue, Nov 01, 2016 at 01:36:26PM +0200, Tariq Toukan wrote:
>> XDP statistics are reported in ethtool as follows:
>> - xdp_drop: the number of packets dropped by xdp.
>> - xdp_tx: the number of packets forwarded by xdp.
>> - xdp_tx_full: the number of times an xdp forward failed
>> 	due to a full tx xdp ring.
>>
>> In addition, all packets that are dropped/forwarded by XDP
>> are no longer accounted in rx_packets/rx_bytes of the ring,
>> so that they count traffic that is passed to the stack.
> This seems like a step backwards, in that I now no longer have any
> statistic whatsoever that can count xdp packets per-ring. For instance,
> how would I validate that my flow-hash rules are operating correctly? I
> would suggest to restore the rxN_packet/bytes stat increment.
The per ring counters are there, and I meant to expose them. Somehow 
they were missed.
I'll add them now.
They're going to be like this:
rx0_xdp_drop
rx0_xdp_tx
rx0_xdp_tx_full

>> Signed-off-by: Tariq Toukan <tariqt@...lanox.com>
>> ---
>>   drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 14 ++++++++++++++
>>   drivers/net/ethernet/mellanox/mlx4/en_netdev.c  |  4 ++++
>>   drivers/net/ethernet/mellanox/mlx4/en_port.c    |  6 ++++++
>>   drivers/net/ethernet/mellanox/mlx4/en_rx.c      | 12 +++++++-----
>>   drivers/net/ethernet/mellanox/mlx4/en_tx.c      |  8 ++++----
>>   drivers/net/ethernet/mellanox/mlx4/mlx4_en.h    |  7 ++++++-
>>   drivers/net/ethernet/mellanox/mlx4/mlx4_stats.h | 10 +++++++++-
>>   7 files changed, 50 insertions(+), 11 deletions(-)
> [...]
Thanks for your comment.

Regards,
Tariq