netdev - Re: [PATCH net] net: Check for fullsock in sock_i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKD1Yr2iC-=f_jwmdmWcfkakgjjyZfj41o78FKJ8nwFSKsGi5A@mail.gmail.com>
Date:   Fri, 4 Nov 2016 02:34:32 +0900
From:   Lorenzo Colitti <lorenzo@...gle.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net] net: Check for fullsock in sock_i_uid()

On Thu, Nov 3, 2016 at 2:18 AM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> Lorenzo, have'nt you already fixed all these bugs ?

Not yet. There's still a fair bit of out-of-tree code left. Other than
per-UID routing, xt_qtaguid is the big one, but there's also xt_quota2
and xt_idletimer. to fix.

> if (skb && skb->sk)
>         timer->uid = from_kuid_munged(current_user_ns(),
>                                  sock_i_uid(skb_to_full_sk(skb)));

Thanks! I didn't know about skb_to_full_sk.