netdev - Re: [PATCH net] dccp: do not release listeners too soon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161103.161927.2250111271074026849.davem@davemloft.net>
Date:   Thu, 03 Nov 2016 16:19:27 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     andreyknvl@...gle.com, gerrit@....abdn.ac.uk, dccp@...r.kernel.org,
        netdev@...r.kernel.org, dvyukov@...gle.com, glider@...gle.com,
        kcc@...gle.com, edumazet@...gle.com, syzkaller@...glegroups.com
Subject: Re: [PATCH net] dccp: do not release listeners too soon

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 02 Nov 2016 17:14:41 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Andrey Konovalov reported following error while fuzzing with syzkaller :
 ...
> It turns out DCCP calls __sk_receive_skb(), and this broke when
> lookups no longer took a reference on listeners.
> 
> Fix this issue by adding a @refcounted parameter to __sk_receive_skb(),
> so that sock_put() is used only when needed.
> 
> Fixes: 3b24d854cb35 ("tcp/dccp: do not touch listener sk_refcnt under synflood")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Andrey Konovalov <andreyknvl@...gle.com>
> Tested-by: Andrey Konovalov <andreyknvl@...gle.com>

Applied and queued up for -stable.