netdev - Re: [Patch net] ipvs: use IPVS_CMD_ATTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161104105843.GC24863@verge.net.au>
Date:   Fri, 4 Nov 2016 11:58:44 +0100
From:   Simon Horman <horms@...ge.net.au>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     netdev@...r.kernel.org, netfilter-devel@...r.kernel.org,
        andreyknvl@...gle.com, Pablo Neira Ayuso <pablo@...filter.org>
Subject: Re: [Patch net] ipvs: use IPVS_CMD_ATTR_MAX for family.maxattr

On Thu, Nov 03, 2016 at 05:14:03PM -0700, Cong Wang wrote:
> family.maxattr is the max index for policy[], the size of
> ops[] is determined with ARRAY_SIZE().
> 
> Reported-by: Andrey Konovalov <andreyknvl@...gle.com>
> Tested-by: Andrey Konovalov <andreyknvl@...gle.com>
> Cc: Pablo Neira Ayuso <pablo@...filter.org>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>


Signed-off-by: Simon Horman <horms@...ge.net.au>

Pablo, can you take this one into nf?

> ---
>  net/netfilter/ipvs/ip_vs_ctl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c
> index c3c809b..a6e44ef 100644
> --- a/net/netfilter/ipvs/ip_vs_ctl.c
> +++ b/net/netfilter/ipvs/ip_vs_ctl.c
> @@ -2845,7 +2845,7 @@ static struct genl_family ip_vs_genl_family = {
>  	.hdrsize	= 0,
>  	.name		= IPVS_GENL_NAME,
>  	.version	= IPVS_GENL_VERSION,
> -	.maxattr	= IPVS_CMD_MAX,
> +	.maxattr	= IPVS_CMD_ATTR_MAX,
>  	.netnsok        = true,         /* Make ipvsadm to work on netns */
>  };
>  
> -- 
> 2.1.0
>