netdev - Re: [PATCH net-next 06/11] net: l3mdev: remove redundant calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0eb5f56b-80dd-0c91-0adb-a91736bbc3f5@cumulusnetworks.com>
Date:   Mon, 7 Nov 2016 08:48:53 -0700
From:   David Ahern <dsa@...ulusnetworks.com>
To:     Lorenzo Colitti <lorenzo@...gle.com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        shm@...ulusnetworks.com
Subject: Re: [PATCH net-next 06/11] net: l3mdev: remove redundant calls

On 11/7/16 3:13 AM, Lorenzo Colitti wrote:
> What should we do here? It would seem that now that
> netif_index_is_l3_master has been resurrected, it's appropriate to use
> it here as well. The user-visible behaviour changed only two months
> ago. Unless we think that RSTs should always mirror the iif, in which
> case I can change our tests accordingly.

Using ingress information (iif in this case) to determine the route for a response seems appropriate.

I can send a patch to revert back to:

	if (!oif && netif_index_is_vrf(net, skb->skb_iif))
		oif = skb->skb_iif;

thanks for the report.