netdev - Re: [PATCH v3 3/4] ptp_clock: allow for it to be optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cc41f1f3-1bc8-1835-1bf1-2d342768e49d@solarflare.com>
Date:   Tue, 8 Nov 2016 13:10:26 +0000
From:   Edward Cree <ecree@...arflare.com>
To:     Nicolas Pitre <nicolas.pitre@...aro.org>,
        John Stultz <john.stultz@...aro.org>,
        Michal Marek <mmarek@...e.com>
CC:     Richard Cochran <richardcochran@...il.com>,
        Paul Bolle <pebolle@...cali.nl>,
        Thomas Gleixner <tglx@...utronix.de>,
        Josh Triplett <josh@...htriplett.org>,
        <netdev@...r.kernel.org>, <linux-kbuild@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 3/4] ptp_clock: allow for it to be optional

On 07/11/16 22:14, Nicolas Pitre wrote:
> In order to break the hard dependency between the PTP clock subsystem and
> ethernet drivers capable of being clock providers, this patch provides
> simple PTP stub functions to allow linkage of those drivers into the
> kernel even when the PTP subsystem is configured out. Drivers must be
> ready to accept NULL from ptp_clock_register() in that case.
>
> And to make it possible for PTP to be configured out, the select statement
> in those driver's Kconfig menu entries is converted to the new "imply"
> statement. This way the PTP subsystem may have Kconfig dependencies of
> its own, such as POSIX_TIMERS, without having to make those ethernet
> drivers unavailable if POSIX timers are cconfigured out. And when support
> for POSIX timers is selected again then the default config option for PTP
> clock support will automatically be adjusted accordingly.
>
> The pch_gbe driver is a bit special as it relies on extra code in
> drivers/ptp/ptp_pch.c. Therefore we let the make process descend into
> drivers/ptp/ even if PTP_1588_CLOCK is unselected.
>
> Signed-off-by: Nicolas Pitre <nico@...aro.org>
> Reviewed-by: Josh Triplett <josh@...htriplett.org>
> Acked-by: Richard Cochran <richardcochran@...il.com>
For the sfc change:
Acked-by: Edward Cree <ecree@...arflare.com>

And I accept that "suggests" isn't needed and the current "imply" semantics
are probably fine.  If not we can always change it or resurrect "suggests".