netdev - Re: [PATCH net-next 0/2] tcp: tcp_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20161109.130319.505221196913812307.davem@davemloft.net>
Date:   Wed, 09 Nov 2016 13:03:19 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, ncardwell@...gle.com, ycheng@...gle.com,
        soheil@...gle.com, eric.dumazet@...il.com
Subject: Re: [PATCH net-next 0/2] tcp: tcp_get_info() locking changes

From: Eric Dumazet <edumazet@...gle.com>
Date: Fri,  4 Nov 2016 11:54:30 -0700

> This short series prepares tcp_get_info() for more detailed infos.
> 
> In order to not slow down fast path, our goal is to use the normal
> socket spinlock instead of custom synchronization.
> 
> All we need to ensure is that tcp_get_info() is not called with
> ehash lock, which might dead lock, since packet processing would acquire
> the spinlocks in reverse way.

Looks really nice, series applied, thanks Eric.

BTW, can we possibly use the netlink NOP trick to align the netlink
attribute data here and avoid these unaligned accesses?

Thanks again.